Re: [PATCH 3/3] x86, cacheinfo: Calculate L3 indexes

[H. Peter Anvin]

On 01/19/2010 03:07 AM, Borislav Petkov wrote:
> We need to know the valid L3 indexes interval when disabling them over
> /sysfs. Do that when the core is brought online and add boundary checks
> to the sysfs .store attribute.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> @@ -161,6 +162,7 @@ struct _cpuid4_info_regs {
>  	union _cpuid4_leaf_ecx ecx;
>  	unsigned long size;
>  	unsigned long can_disable;
> +	unsigned int l3_indexes;
>  };
>  

Hmmm... 32, 64, 64, 32 bits... we could move up the l3_indexes variable
here.   However, more likely is that "size" and "can_disable" have no
business being unsigned long in the first place -- especially the latter
seems to be actually used as a boolean, and really should be "bool".

Second, the preferred plural of "index" is "indices" (although both are
correct and present in the kernel source.)

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/