Re: [RFC][PATCH] PM / Runtime: Add sysfs switch for disablingdevice run-time PM

[Greg KH]

On Wed, Jan 20, 2010 at 09:55:36PM +0100, Rafael J. Wysocki wrote:
> On Wednesday 20 January 2010, Greg KH wrote:
> > On Mon, Jan 18, 2010 at 01:29:55AM +0100, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > > Subject: PM / Runtime: Add sysfs switch for disabling device run-time PM
> > > 
> > > Add new device sysfs attribute, power/runtime, allowing the user
> > > space to block the run-time power management of the device.  If this
> > > attribute is set to "disabled", the driver of the device won't be
> > > able to enable run-time power management for it (without breaking the
> > > rules).
> > > 
> > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > > ---
> > >  drivers/base/power/power.h   |    4 +
> > >  drivers/base/power/runtime.c |  107 +++++++++++++++++++++++++++++++++----------
> > >  drivers/base/power/sysfs.c   |   46 ++++++++++++++++++
> > >  include/linux/pm.h           |    1 
> > >  include/linux/pm_runtime.h   |   11 +---
> > >  5 files changed, 139 insertions(+), 30 deletions(-)
> > 
> > You forgot to also add an entry into Documentation/ABI/ for when you
> > add/change a sysfs file :)
> 
> There's no description for /sys/devices/.../power/wakeup in there too and
> that one has been present for quite some time already.
> 
> I'd prefer adding them both in a separate patch if you don't mind.

That's fine with me, as long as you add them :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/