Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops

From: Alexey Dobriyan
Date: Wed Jan 20 2010 - 05:48:25 EST


On Wed, Jan 20, 2010 at 12:08 PM, <monstr@xxxxxxxxx> wrote:
> From: Michal Simek <monstr@xxxxxxxxx>
>
> Check that dma_ops are initialized correctly. Without this
> checking you get kernel fault and you don't know where the problem is.

Oh, yes you do. PC will be of some small value.

> +       BUG_ON(!ops);
>        BUG_ON(!valid_dma_direction(dir));
>        addr = ops->map_page(dev, virt_to_page(ptr),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/