Re: linux-next: pci tree build failure

From: Jesse Barnes
Date: Tue Jan 19 2010 - 23:40:08 EST


Pushed this fix out to linux-next, thanks.

Jesse

On Mon, 18 Jan 2010 19:40:50 +1100
Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> Hi Jesse,
>
> Today's linux-next build (ppc64 allyesconfig) failed like this:
>
> In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
> include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'acpi_find_root_bridge_handle'
>
> This file was added in commit f3adb5a4f2e1dfdf9482af05481d0928a39477e8
> ("PCI PM: PCIe PME root port service driver") from the pci tree and
> seems to depend on ACPI. Maybe its building should depend on
> CONFIG_ACPI?
>
> I added the following patch for today (I presume there is a better
> fix):
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Mon, 18 Jan 2010 19:36:11 +1100
> Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
> drivers/pci/pcie/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index cf3c35f..b8b494b 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
>
> config PCIE_PME
> def_bool y
> - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
> + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/