Re: [PATCH] watchdogs: constify struct watchdog_info

From: Joe Perches
Date: Tue Jan 19 2010 - 15:28:24 EST


On Tue, 2010-01-19 at 09:56 +0100, Wim Van Sebroeck wrote:
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> > drivers/watchdog/acquirewdt.c | 2 +-
> ...
> > drivers/watchdog/wm8350_wdt.c | 2 +-
> > 51 files changed, 52 insertions(+), 52 deletions(-)
>
> NAK (Although the patch itself is good).

No worries.

> I created another patch that does this and moves the struct
> out of the ioctl call as part of the generic watchdog conversion.

Great.

I did send you awhile ago a patch series
to convert to pr_fmt() and pr_<level>.

http://lkml.org/lkml/2009/7/21/5

Do you still eventually want those?

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/