Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()

From: Jarek Poplawski
Date: Tue Jan 19 2010 - 05:47:56 EST


On Tue, Jan 19, 2010 at 12:46:24AM -0500, Michael Breuer wrote:
> Ok - one last update for a while ...not sure what's next... I put some
> printk's into sky2.c xmit logic - the packets are being sent to the
...

Btw, could you try if this patch can makes difference in triggering
the "lib/dma-debug.c:898" warning?

Jarek P.
---

drivers/net/sky2.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 7650f73..e02e9e9 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -2479,6 +2479,9 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do, u16 idx)

port = le->css & CSS_LINK_BIT;
dev = hw->dev[port];
+ if (!netif_running(dev))
+ continue;
+
sky2 = netdev_priv(dev);
length = le16_to_cpu(le->length);
status = le32_to_cpu(le->status);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/