Re: [perfmon2] [PATCH] perf: fix the is_software_event() definition

[stephane eranian]

On Mon, Jan 18, 2010 at 12:53 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Mon, 2010-01-18 at 12:13 +0100, Peter Zijlstra wrote:
>> On Sun, 2010-01-17 at 15:12 +0100, Frederic Weisbecker wrote:
>>
>> > You need to also call pmu->disable() if it is a software event,
>> > because a breakpoint needs to be unregistered in hardware level
>> > too.
>>
>> breakpoint isn't a software pmu. But yeah, enable and disable need to
>> match.
>
> That is, it shouldn't be a software pmu, because we assume software
> events can always be scheduled, whereas that's definitely not so for the
> breakpoint one.
>
> Which seems to suggest the following
>
> ---
> Subject: perf: fix the is_software_event() definition
>
> When adding the breakpoint pmu Frederic forgot to exclude it from being
> a software event. While we're at it, make it an inclusive expression.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> ---
> Âinclude/linux/perf_event.h | Â 10 +++++++---
> Â1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index c66b34f..835ba26 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -814,9 +814,13 @@ extern int perf_event_overflow(struct perf_event *event, int nmi,
> Â*/
> Âstatic inline int is_software_event(struct perf_event *event)
> Â{
> - Â Â Â return (event->attr.type != PERF_TYPE_RAW) &&
> - Â Â Â Â Â Â Â (event->attr.type != PERF_TYPE_HARDWARE) &&
> - Â Â Â Â Â Â Â (event->attr.type != PERF_TYPE_HW_CACHE);
> + Â Â Â switch (event->attr.type) {
> + Â Â Â case PERF_TYPE_SOFTWARE:
> + Â Â Â case PERF_TYPE_TRACEPOINT:
> + Â Â Â case PERF_TYPE_HW_CACHE:
> + Â Â Â Â Â Â Â return 1;
> + Â Â Â }
> + Â Â Â return 0;
> Â}
>
> Âextern atomic_t perf_swevent_enabled[PERF_COUNT_SW_MAX];
>
PERF_TYPE_HW_CACHE is a hardware PMU event.


>
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> _______________________________________________
> perfmon2-devel mailing list
> perfmon2-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/