Re: [PATCH]cfq-iosched: don't take requests with long distence as close

From: Jeff Moyer
Date: Fri Jan 15 2010 - 15:26:15 EST

Corrado Zoccolo <czoccolo@xxxxxxxxx> writes:

> On Fri, Jan 15, 2010 at 8:45 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
>> Corrado Zoccolo <czoccolo@xxxxxxxxx> writes:
>>> Hi Jeff,
>>> I think this patch has the same flaw as Shaohua's.
>>> The seekiness check that you introduce in cfq_rq_close is already
>>> present in its caller, cfq_close_cooperator, so it is not effective.
>> I don't think so. ÂThere are two queues, here. ÂOne queue is checked by
>> the caller, and that is the cur_cfqq. ÂThe __cfqq needs to also be
>> checked.
> The other one, i.e. the returned one, is also checked by the caller,
> some lines below.

haha. OK, I guess I wrote it right the first time? ;-)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at