RE: [RFC] [PATCH] Adding Intel Moorestown PMIC Battery Driver
From: Mahalingam, Nithish
Date: Fri Jan 15 2010 - 08:19:31 EST
>>>> + unsigned int batt_charge_now; /* in mAS */
>>>> + unsigned int batt_prev_charge_full; /* in mAS */
>>> + unsigned int batt_charge_rate; /* in units per second */
>>>
>>> Per include/linux/power_supply.h and
>>> Documentation/power/power_supply_class.txt
>>>
>>> * All voltages, currents, charges, energies, time and temperatures in uV,
>>> * uA, uAh, uWh, seconds and tenths of degree Celsius unless otherwise
>>> * stated. It's driver's job to convert its raw values to units in which
>>> * this class operates.
>>
>> I just now checked the hardware spec and it is indeed mAh. I will correct
>> the comment appropriately.
>
> Note, if the hardware reports the values in mAh (milli), the driver
> still have to convert them to uAh (micro) before reporting the values
> to userspace.
Yup will take care, sorry for not making it clear here.
Regards,
Nithish
N§²æìr¸yúèØb²X¬¶ÇvØ^)Þ{.nÇ+·¥{±êçzX§¶¡Ü}©²ÆzÚ&j:+v¨¾«êçzZ+Ê+zf£¢·h§~Ûiÿûàz¹®w¥¢¸?¨èÚ&¢)ßfù^jÇy§m
á@A«a¶Úÿ0¶ìh®åi