Re: [PATCH 2.6.33] s3c-fb: Fix handling of missing refresh inplatform data

From: Mark Brown
Date: Thu Jan 14 2010 - 05:20:36 EST

On Thu, Jan 14, 2010 at 07:36:17AM +0000, Ben Dooks wrote:

> Thirdly he's changed the code to calculate the divider to assume pixclk
> is a frequency, and not a time-period. It clearly stats in the docs
> that pixclk is in picoseconds. Our clock rate is in Hz.

> It seems I wasn't cc'd on the original submission or I'd have said no.

> I'd rather see this one reverted.

A revert also does the job for SMDK6410 (and does it better) so that
sounds good to me too - I'd been wondering why I couldn't figure out
what was supposed to go in there. I'll send something out with a
changelog shortly.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at