Re: [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark aftershrink zone

[Rik van Riel]

On 01/10/2010 06:48 PM, Minchan Kim wrote:
>   * V2
>    * Add reviewed-by singed-off (Thanks Kosaki, Wu)
>    * Fix typo of changelog
>
> == CUT HERE ==
>
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> !all_zone_ok makes kswapd retry not sleeping.
>
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaninful.
>
> This patch move the check after shrink zone.
>
> Signed-off-by: Minchan Kim<minchan.kim@xxxxxxxxx>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
> Reviewed-by: Wu Fengguang<fengguang.wu@xxxxxxxxx>
> CC: Mel Gorman<mel@xxxxxxxxx>
> CC: Rik van Riel<riel@xxxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/