Re: + hugetlb-fix-section-mismatch-warning-in-hugetlbc.patch added to -mm tree

From: Rakib Mullick
Date: Fri Jan 08 2010 - 01:34:23 EST

On 1/8/10, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> Hi,
> If so, then hugetlb_register_node() could be called at any time
> (like after system init), and it would then call
> hugetlb_sysfs_add_hstate(), which would be bad.
But - hugetlb_register_node is only called from hugetlb_register_all_nodes.
The call sequence is :
hugetlb_init ---------------> was __init
\-> hugetlb_register_all_nodes ----> we make it __init
\-> hugetlb_register_node
---> we make it __init
hugetlb_sysfs_add_hstate -> this was __init

Above all happens in __init context. So - hugetlb_register_node is
called only at
system init. But I don't think __init is used for hotplug support, for
proper hotplug
support we might use __meminit.

And register_hugetlbfs_with_node is called from hugetlb_un/register_node.
But hugetlb_unregister_node doesn't use callback function. It's not referencing
hugetlb_sysfs_add_hstate(). So - it's safe. Unless I'm not missing
anything, too.


> Thanks.
> ---
> ~Randy
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at