Re: [GIT PULL] Please pull NFS client bugfixes....

[Linus Torvalds]

On Thu, 7 Jan 2010, Trond Myklebust wrote:
> 
> Yes. I want to pursue Peter Zijlstra's patches, which split up the mmap
> function into a set of parts which require the mmap_sem, and other parts
> which don't, and that adds a filesystem callback that allows for
> revalidation to occur outside the mmap_sem.

I'm sorry, but that just sounds STUPID.

Why?

Because it means that you can trivially take page faults before the thing 
is validated (think threads).

If that is ok, then why do the revalidate at all? Just do the open/close 
consistency and validate at open time, not mmap time.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/