Re: [PATCH 1/2] perf: add close()/closedir() calls when needed

[H. Peter Anvin]

On 01/07/2010 02:44 PM, Alexander Beregalov wrote:
> 2010/1/8 Paul Mackerras <paulus@xxxxxxxxx>:
>> On Thu, Jan 07, 2010 at 07:40:46PM +0300, Alexander Beregalov wrote:
>>
>>> Close file and directory descriptors before exiting or dying.
>>
>> Your patch description doesn't say why that's a good thing to do, and
>> it's not obvious to me at least.  Please explain the motivation in
>> your patch description.
> 
> Isn't it a good style to close files after use and before exit?

exit() closes all files, so it's redundant.

It's "good style" in the sense that it can help librarization, though.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/