Re: [PATCH] cfq-iosched: non-rot devices do not need read queue merging

[Kirill Afonshin]

I think we should not rely on NCQ/non-NCQ or blk_queue_nonrot() because it may be incorrect:
try this:

find /sys/ -name rotational 2>/dev/null
find /sys/ -name rotational 2>/dev/null|xargs cat

all devices are reported as rotational for me including ram, loop and usb flash drive. Physical block size and optimal io size has invalid values for all my usb flash drives.
 
I think it would be better to do a short performance test before mount. It will provide all necessary information for io scheduler. We doesn't need information about NCQ and rotational. We need to predict how much time specific io operation will take in current context.

PS: I'm not native speaker.

Best regards,
Kirill Afonshin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/