Re: [PATCH -mmotm] build fix formemcg-move-charges-of-anonymous-swap.patch

[KAMEZAWA Hiroyuki]

On Thu, 7 Jan 2010 14:14:01 +0900
Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:

> Anyway, I'm sorry that the first patch was wrong...
> This is the correct one.
> 
> ===
> From: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
> 
> build fix in !CONFIG_SWAP case.
> 
>   CC      mm/memcontrol.o
> mm/memcontrol.c: In function 'is_target_pte_for_mc':
> mm/memcontrol.c:3648: error: implicit declaration of function 'mem_cgroup_count_swap_user'
> make[1]: *** [mm/memcontrol.o] Error 1
> make: *** [mm] Error 2
> 
> Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>

Thank you.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

BTW, maybe it's time to
  - remove EXPERIMENTAL from CONFIG_CGROUP_MEM_RES_CTRL_SWAP
and more,
  - remove CONFIG_CGROUP_MEM_RES_CTRL_SWAP
    (to reduce complicated #ifdefs and replace them with CONFIG_SWAP.)

It's very stable as far as I test.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/