Re: [PATCH] Logitech G13 driver 0.0.2

From: Andrew Morton
Date: Wed Jan 06 2010 - 17:46:08 EST


On Mon, 14 Dec 2009 15:44:46 -0700
"Rick L. Vinyard Jr." <rvinyard@xxxxxxxxxxx> wrote:

> his is a driver for the Logitech G13 gamepad, and contains three
> key parts. In the USB reports the device identifies itself as a
> HID, and as a result this driver is under the HID framework.
>
> There are two primary sub-components to this driver; an input
> device and a framebuffer device.
>
> Although identified as a HID, the device does not support standard
> HID input messages. As a result, a sub-input device is allocated and
> registered separately in g13_probe(). The raw events are monitored
> and key presses/joystick activity is reported through the input device
> after referencing an indexed keymap.
>
> Additionally, this device contains a 160x43 monochrome LCD display.
> A registered framebuffer device manages this display. The design
> of this portion of the driver was based on the design of the
> hecubafb driver with deferred framebuffer I/O since there is
> no real memory to map.

I get this from x86_64 allmodconfig:

drivers/hid/hid-g13.o:(.rodata+0x0): multiple definition of `__mod_hid_device_table'
drivers/hid/hid-lg.o:(.rodata+0x0): first defined here
/opt/crosstool/gcc-4.0.2-glibc-2.3.6/x86_64-unknown-linux-gnu/bin/x86_64-unknown-linux-gnu-ld: Warning: size of symbol `__mod_hid_device_table' changed from 552 in drivers/hid/hid-lg.o to 48 in drivers/hid/hid-g13.o
drivers/hid/hid-g13.o: In function `init_module':
hid-g13.c:(.init.text+0x0): multiple definition of `init_module'
drivers/hid/hid-lg.o:hid-lg.c:(.init.text+0x0): first defined here
drivers/hid/hid-g13.o: In function `cleanup_module':
hid-g13.c:(.exit.text+0x0): multiple definition of `cleanup_module'
drivers/hid/hid-lg.o:hid-lg.c:(.exit.text+0x0): first defined here

Confused.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/