Re: [PATCH 4/12] PCI PM: Make it possible to force using INTx forPCIe PME signaling

From: Jesse Barnes
Date: Wed Jan 06 2010 - 16:56:34 EST


On Sun, 27 Dec 2009 21:02:22 +0100
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> From: Rafael J. Wysocki <rjw@xxxxxxx>
>
> Apparently, some machines may have problems with PCI run-time power
> management if MSIs are used for the hative PCIe PME signaling. In
> particular, on the MSI Wind U-100 PCIe PME interrupts are not
> generated by a PCIe root port after a resume from suspend to RAM, if
> the system wake-up was triggered by a PME from the device attached to
> this port. [It doesn't help to free the interrupt on suspend and
> request it back on resume, even if that is done along with disabling
> the MSI and re-enabling it, respectively.] However, if INTx
> interrupts are used for this purpose on the same machine, everything
> works just fine.
>
> For this reason, add a kernel command line switch allowing one to
> request that MSIs be not used for the native PCIe PME signaling,
> introduce a DMI table allowing us to blacklist machines that need
> this switch to be set by default and put the MSI Wind U-100 into this
> table.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> ---

This scares me a little... seems like we're not restoring some state on
resume that's needed for MSIs to work? Looks fine though.

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/