Re: [PATCH 4/7] Memory compaction core

[Andi Kleen]

Mel Gorman <mel@xxxxxxxxx> writes:


Haven't reviewed the full thing, but one thing I noticed below:

> +
> +	/*
> +	 * Isolate free pages until enough are available to migrate the
> +	 * pages on cc->migratepages. We stop searching if the migrate
> +	 * and free page scanners meet or enough free pages are isolated.
> +	 */
> +	spin_lock_irq(&zone->lock);

Won't that cause very long lock hold times on large zones?
Presumably you need some kind of lock break heuristic.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/