Re: [PATCH] DFU Driver for Atheros bluetooth chipset AR3011

[Marcel Holtmann]

Hi Vikram,

> Signed-off-by: Vikram Kandukuri <vikram.kandukuri@xxxxxxxxxxx>
> Signed-off-by: Alicke Xu <sxu@xxxxxxxxxxx>
> Reviewed-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
> ---
>  drivers/bluetooth/Kconfig  |   13 +++-
>  drivers/bluetooth/Makefile |    1 +
>  drivers/bluetooth/ath3k.c  |  187 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 200 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/bluetooth/ath3k.c

patch has been applied to my trees.

However I still had to hand edit in various small ares. For example
BT_DBG doesn't require the \n newline. So you have never actually tested
the debug code. Otherwise you would have seen that something is off.
Also there were still a bunch of spaces in the code that I had to fix
manually.

Also I prefer if you a bit more consistent writing "Bluetooth" exactly
this way in comment and descriptions. It is brand name and the writing
is suppose to be consistent.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/