Re: [PATCH alt.2] af_packet: Don't use skb after dev_queue_xmit()

From: Jarek Poplawski
Date: Wed Jan 06 2010 - 14:40:33 EST


On Wed, Jan 06, 2010 at 06:49:57AM -0800, Stephen Hemminger wrote:
> On Wed, 6 Jan 2010 09:15:32 +0000
> Jarek Poplawski <jarkao2@xxxxxxxxx> wrote:
>
> > tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> > which is illegal.
> >
> > With debugging by: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
> >
> > Reported-by: Michael Breuer <mbreuer@xxxxxxxxxx>
> > Signed-off-by: Jarek Poplawski <jarkao2@xxxxxxxxx>
>
> Good catch.
> Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

First of all, we're incredibly lucky that such a helpful guy as
Michael had misfortune to hit so helpfully broken piece of hardware ;-)

Thanks,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/