Re: [PATCH] Fix markup_oops.pl get error in x86

[Arjan van de Ven]

On 1/6/2010 1:23, Hui Zhu wrote:
>   	}
> $func_offset will get a number like "0x2"
> But in follow code:
> my $decodestart = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$func_offset");
> It add other ox to ox2.
> Then this value will be set to NaN.
>
> So I make a small patch to fix it.

> -	if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
> +	if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {

I think this makes sense, but would you not also need to add "x" to the list of allowed characters?
so   [a-f0-9x]
?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/