Re: [PATCH 5/4] mfd: Don't allow WM8350 to be built modular

From: Samuel Ortiz
Date: Wed Jan 06 2010 - 03:54:53 EST


Hi Mark,

On Tue, Jan 05, 2010 at 08:40:47PM +0000, Mark Brown wrote:
> The genirq implementation does not allow modules to implement irq_chips
> so the conversion of WM8350 to genirq means we can no longer allow the
> driver to be built as a module.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
> Sorry, I thought I'd sent a patch for this earlier but I appear to be
> imagining things.
No problem, patch applied.

Cheers,
Samuel.

> drivers/mfd/Kconfig | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8782978..1414cec 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -205,7 +205,7 @@ config MFD_WM831X
> functionality of the device.
>
> config MFD_WM8350
> - tristate
> + bool
>
> config MFD_WM8350_CONFIG_MODE_0
> bool
> @@ -256,9 +256,9 @@ config MFD_WM8352_CONFIG_MODE_3
> depends on MFD_WM8350
>
> config MFD_WM8350_I2C
> - tristate "Support Wolfson Microelectronics WM8350 with I2C"
> + bool "Support Wolfson Microelectronics WM8350 with I2C"
> select MFD_WM8350
> - depends on I2C
> + depends on I2C=y
> help
> The WM8350 is an integrated audio and power management
> subsystem with watchdog and RTC functionality for embedded
> --
> 1.6.5.7
>

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/