Re: [PATCH] sparc: copy_from_user() should not return -EFAULT

From: Arnd Bergmann
Date: Tue Jan 05 2010 - 12:57:06 EST


On Tuesday 05 January 2010, Heiko Carstens wrote:
> Subject: [PATCH] sparc: copy_from_user() should not return -EFAULT
>
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> Callers of copy_from_user() expect it to return the number of bytes
> it could not copy. In no case it is supposed to return -EFAULT.
>
> In case of a detected buffer overflow just return the requested
> length. In addition one could think of a memset that would clear
> the size of the target object.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

The xtensa clear_user function seems to have a similar issue,
it should return size on failure, not -EFAULT.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/