Re: s390 && user_enable_single_step() (Was: odd utrace testingresults on s390x)

From: Oleg Nesterov
Date: Tue Jan 05 2010 - 10:47:38 EST


On 01/05, Oleg Nesterov wrote:
>
> Anyway. I modified the debugging patch a bit:
>
> --- K/arch/s390/kernel/traps.c~ 2009-12-22 10:41:52.909174198 -0500
> +++ K/arch/s390/kernel/traps.c 2010-01-05 09:49:19.541792379 -0500
> @@ -384,6 +384,8 @@ void __kprobes do_single_step(struct pt_
> }
> if (tracehook_consider_fatal_signal(current, SIGTRAP))
> force_sig(SIGTRAP, current);
> + else
> + printk("XXX: %d %d\n", current->pid, test_thread_flag(TIF_SINGLE_STEP));
> }
>
> static void default_trap_handler(struct pt_regs * regs, long interruption_code)
> -------------------------------------------------------------------------------

Ah, please ignore. I guess TIF_SINGLE_STEP was already cleared by the caller
in entry.S

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/