Re: [PATCH v2] scripts: add ARM support to decodecode

[Michal Marek]

On 5.1.2010 16:06, Arjan van de Ven wrote:
> On Tue, 5 Jan 2010 20:27:58 +0530
> Rabin Vincent <rabin@xxxxxx> wrote:
> 
>> This patch adds support for decoding ARM oopses to scripts/decodecode.
>> The following things are handled:
>>
>>  - ARCH and CROSS_COMPILE environment variables are respected.
>>
>>  - The Code: in x86 oopses is in bytes, while it is in either words (4
>>    bytes) or halfwords for ARM.
>>
>>  - Some versions of ARM objdump refuse to disassemble instructions
>>    generated by literal constants (".word 0x...").  The workaround is
>> to strip the object file first.
>>
>>  - The faulting instruction is marked (liked so) in ARM, but <like so>
>>    in x86.
>>
>>  - ARM mnemonics may include characters such as [] which need to be
>>    escaped before being passed to sed for the "<- trapping
>> instruction" substitution.
> 
> 
> I'm fine with this,

Was this an Acked-by? :)


> but I wonder if ARM could switch to the <>
> convention for the faulting instruction, just to keep things
> consistent..

I added the patch to the kbuild tree. () won't appear in the x86 Code:
line, so there should be no problem.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/