Re: [PATCH] kernel/time/jiffies.c: local symbols should be static

From: john stultz
Date: Mon Jan 04 2010 - 18:43:22 EST


On Mon, 2009-12-28 at 11:59 -0500, H Hartley Sweeten wrote:
> The symbol 'clocksource_jiffies' is not exported and should be static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: John Stultz <johnstul@xxxxxxxxxx>

Yep, clocksource_jiffies has stopped being used elsewhere, so this can
be cleaned up.

Acked-by: John Stultz <johnstul@xxxxxxxxxx>

thanks
-john



> ---
>
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..36d2d83 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
> return (cycle_t) jiffies;
> }
>
> -struct clocksource clocksource_jiffies = {
> +static struct clocksource clocksource_jiffies = {
> .name = "jiffies",
> .rating = 1, /* lowest valid rating*/
> .read = jiffies_read,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/