Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

From: Pavel Machek
Date: Mon Jan 04 2010 - 17:48:34 EST


Hi!

> > Well, the device is still primarily HID device in its nature, so either
> > keeping the whole driver in drivers/hid, or separating it into two
> > drivers, one for the HID part and second for the framebuffer part should
> > be acceptable.
>
> The framebuffer part uses the same interrupt endpoint for both HID and
> display. IIRC there were issues with two drivers using the same interrupt
> endpoint.

Ok, but I guess you should cc auxdisplay people in future.

> >> I'd prefer to go without another logo. Just make sure default penguin
> >> gets
> >> there or something.
> >
> > What logo is this, BTW? :)
>
> It's similar to the default G13 load image, but with tux on the left and
> the GNU gnu on the right.
>
> I tried to particularly clean up tux a bit since the default monochrome
> logo is 80x80 and the display is 160x43.
>
> The only alternatives I could think of were to use the default logo and
> load it at 80x43 which cuts off Tux at the nipples, resample in the
> driver, or leave the logo off.

Or put something simple&stupid there like checkerboard?

Or just resample penguin -- skipping every second line should not be
particulary hard...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/