Re: [PATCH] [4/6] kfifo: add kfifo_out_peek

[Andrew Morton]

On Mon, 28 Dec 2009 00:41:37 +0100
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Sun, Dec 27, 2009 at 10:49:49PM +0100, Stefani Seibold wrote:
> > Am Sonntag, den 27.12.2009, 22:03 +0100 schrieb Andi Kleen:
> > > In some upcoming code it's useful to peek into a FIFO without
> > > permanentely removing data. This patch implements a new 
> > > kfifo_out_peek() to do this. 
> > > 
> > 
> > Yes this function can be useful. I will implement it in the macro
> > version of the kfifo.
> 
> Well that doesn't help me -- I need a working kfifo on a 2.6.33
> base. Or do you want to abandon the old interface?
> 
> I must say I'm a little surprised by the general tone of  
> your comments -- first you submit these patches all the time and when they 
> finally get reviewed and merged and people start to use them and make them 
> production ready you state it's all abandoned.

Yup, the first priority is to get the 2.6.33 code fixed up.  It is
unwise to assume that we'll be merging some other patch some time in
the future.

Macros are unpopular, for good reasons.  But the case for a
template-based container such as this is a good one.  However I worry
about the code bloat whcih the macro version might add.  We worry about
all this later on.

> 
> Anyways Andrew could you please merge these fixes? Thanks.

I shall.  Stefani, pelase review those patches for 2.6.33 suitability. 
Let's not worry about a big rewrite at this time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/