Re: [PATCH] VLYNQ: add missing linux/irq.h include

From: Florian Fainelli
Date: Mon Jan 04 2010 - 15:22:39 EST


Hi Christoph,

Le lundi 4 janvier 2010 19:12:28, Christoph Hellwig a écrit :
> On Mon, Jan 04, 2010 at 06:38:51PM +0100, Florian Fainelli wrote:
> > This patch adds the missing linux/irq.h header
> > which will trigger compilation errors on non-AR7
> > platforms (i.e: TI Davinci).
>
> linux/irq.h should not be included by drivers. It's an internal handler
> for the generic hardirq code. All functions for use by drivers are in
> linux/interrupt.h

vlynq.c references definitions that are in linux/irq.h and not in
linux/interrupt.h (like IRQ_TYPE_*), thus the include.
--
Best regards, Florian Fainelli
Email: florian@xxxxxxxxxxx
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/