RE: [PATCH 1/2] drivers/block: drop unnecesary memset

[Miller, Mike (OS Dev)]

> -----Original Message-----
> From: Julia Lawall [mailto:julia@xxxxxxx] 
> Sent: Saturday, December 19, 2009 1:30 AM
> To: Miller, Mike (OS Dev); ISS StorageDev; 
> linux-kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/2] drivers/block: drop unnecesary memset
> 
> From: Julia Lawall <julia@xxxxxxx>
> 
> memset of 0 is not needed after kzalloc
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x;
> statement S;
> @@
> 
> x = kzalloc(...);
> if (x == NULL) S
> ... when != x
> -memset(x,0,...);// </smpl>
> 
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Acked-by: Mike Miller <mike.miller@xxxxxx>

> 
> ---
>  drivers/block/cciss.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff -u -p a/drivers/block/cciss.c b/drivers/block/cciss.c
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -4379,7 +4379,6 @@ static void cciss_shutdown(struct pci_de
>  		return;
>  	}
>  	/* write all data in the battery backed cache to disk */
> -	memset(flush_buf, 0, 4);
>  	return_code = sendcmd_withirq(CCISS_CACHE_FLUSH, 
> h->ctlr, flush_buf,
>  		4, 0, CTLR_LUNID, TYPE_CMD);
>  	kfree(flush_buf);
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/