Re: [PATCH v2] timer: Introduce mod_timer_msec()

From: Arjan van de Ven
Date: Sat Jan 02 2010 - 14:33:54 EST


On Sat, 2 Jan 2010 11:30:13 -0800
Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

timer returns 1.)
> > + */
> > +int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
> >+{
> > + return mod_timer(timer, jiffies + msecs_to_jiffies(delay_ms));
> > +}
> > +EXPORT_SYMBOL(mod_timer_msec);
>
> I wonder why isn't this an inline function? Seems tiny enough...

the next step I want to do is to add some more smarts here, around rounding/grouping etc;
it'll take some more infrastructure work in the timer system first, but if I'd
made this inline now I'd just have to uninline it a bit later...

> Other than that - I'll gladly take input conversion patches.

great!



--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/