Re: [PATCH] pata_cmd64x: fix overclocking of UDMA0-2 modes

From: Jeff Garzik
Date: Sun Dec 20 2009 - 15:46:23 EST

On 12/20/2009 01:22 PM, Bartlomiej Zolnierkiewicz wrote:

adev->dma_mode stores the transfer mode value not UDMA mode number
so the condition in cmd64x_set_dmamode() is always true and the higher
UDMA clock is always selected. This can potentially result in data
corruption when UDMA33 device is used, when 40-wire cable is used or
when the error recovery code decides to lower the device speed down.

The issue was introduced in the commit 6a40da0 ("libata cmd64x: whack
into a shape that looks like the documentation") which goes back to
kernel 2.6.20.

Cc: stable@xxxxxxxxxx
Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx>
it is patch #116 in my local working queue but I thought it would
be nice to get it upstream ahead of other patches..

drivers/ata/pata_cmd64x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at