Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored inbcm54xx_adjust_rxrefclk()

From: Matt Carlson
Date: Thu Dec 17 2009 - 20:41:53 EST


On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
> If not signed read errors are ignored.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>

Acked-by: Matt Carlson <mcarlson@xxxxxxxxxxxx>

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index f63c96a..c13cf64 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -326,7 +326,8 @@ error:
>
> static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
> {
> - u32 val, orig;
> + u32 orig;
> + int val;
> bool clk125en = true;
>
> /* Abort if we are using an untested phy. */
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/