Re: GPIO support for HTC Dream

From: Arve Hjønnevåg
Date: Tue Dec 15 2009 - 01:48:10 EST


On Sun, Dec 13, 2009 at 10:45 PM, Pavel Machek <pavel@xxxxxx> wrote:
>> > +int __init dream_init_gpio(void)
>> > +{
>> > +        int i;
>> > +
>> > +        for (i = 0; i < ARRAY_SIZE(msm_gpio_banks); i++)
>> > +                gpiochip_add(&msm_gpio_banks[i].chip);
>> > +
>> > +   return 0;
>> > +}
>>
>> Your original patch was initially writing the shadow values to the registers.
>> Do you still need to do that?
>
> It seems to boot this way :-). If writing the shadow values is not
> needed, lets try getting away without it...

I may boot this way, but unless you know that the bootloader
initialized all the registers to the same value, some outputs will be
in the wrong state until someone writes to a gpio in the same bank.

--
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/