Re: [PATCH 8/8] mm: Give up allocation if the task have fatal signal

From: KOSAKI Motohiro
Date: Mon Dec 14 2009 - 19:50:55 EST


> > /*
> > + * If the allocation is for userland page and we have fatal signal,
> > + * there isn't any reason to continue allocation. instead, the task
> > + * should exit soon.
> > + */
> > + if (fatal_signal_pending(current) && (gfp_mask & __GFP_HIGHMEM))
> > + goto nopage;
>
> If we jump nopage, we meets dump_stack and show_mem.
> Even, we can meet OOM which might kill innocent process.

Which point you oppose? noprint is better?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/