Re: [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem *

[David Miller]

From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Date: Sun, 13 Dec 2009 01:54:08 +0300

> H Hartley Sweeten wrote:
> 
>> The ioremap return value is an __iomem *, not an integer.  Update the
>> private structure to reflect this.  While here, remove the typedef
>> for _auide_hwif and just use struct auide_hwif instead as recommended
>> by Documentation/CodingStyle.
>>
>> auide_setup_ports() still needs to cast the regbase back to an integer
>> to correctly setup the io_ports_array.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
 ...
>>     a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
>> -     containes : struct _auide_hwif
>> +     containes : struct auide_hwif
>>   
> 
>   Contains?
> 
>   Other than that,
> 
> Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

Also, this patch doesn't apply to the current tree, the
au_ide_remove() function has been fixed to use
resource_size().

Please respin your patch, and also incorporate the
documentation spelling fix suggested by Sergei (and
make sure to keep the alignment of that section of
documentation when you do that).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/