Re: [PATCH] tracing: add checks for printing graph irq

From: Frederic Weisbecker
Date: Fri Dec 11 2009 - 12:44:45 EST


On Fri, Dec 11, 2009 at 10:00:50AM -0500, Steven Rostedt wrote:
> On Fri, 2009-12-11 at 12:19 +0100, Frederic Weisbecker wrote:
> > On Fri, Dec 11, 2009 at 05:38:35PM +0800, Wenji Huang wrote:
> > > Check return value of trace_seq_printf.
> > >
> > > Signed-off-by: Wenji Huang <wenji.huang@xxxxxxxxxx>
> > > ---
> >
> >
> > I'm applying it, I'll send the fix for the problem you've reported
> > at the same time.
>
> As for my comment to the patch. Please do not apply this.
>
> Thanks,


Ok. Yeah you're right, the seq buffer will refuse them once
it's fullfilled anyway, so only the last check matters, we have
too much of these checks in the current code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/