Re: [PATCH 0/2] Add support for Sphairon Homelink 1202 USB WLAN

[John W. Linville]

On Fri, Dec 11, 2009 at 01:36:03PM +0100, Stefan Seyfried wrote:
> On Tue,  8 Dec 2009 15:21:33 +0100
> Stefan Seyfried <stefan.seyfried@xxxxxxxxxxxxxx> wrote:
> 
> > From: Stefan Seyfried <seife@xxxxxxxxxxxx>
> > 
> > The following two trivial patches add support for this device to
> > zd1211rw (ejecting the virtual USB drive) and ar9170usb (that drives
> > the WLAN chip inside).
> 
> Is anyhting wrong with those?
> Are those too trivial and "USB only" and thus better suited for direct
> submission to Greg?

Trivial or not, they are wireless LAN patches and they go here.

FWIW, you posted them in the middle of the maintainer's merge window
for 2.6.33.  So for now only fixes are being merged.  I wasn't sure
these qualified, although upon closer review they may.

It strikes me as strange that you are hitting two drivers to support
one device.  Are you saying that your ar9170usb has the goofy storage
device thing using the same USB IDs that the zd1211rw devices like that
used?  I suppose that makes some sense given the shared heritage...

We did just have a long (and possibly unresolved thread) about
this type of practice (i.e. eject in the driver) not too long ago.
But since zd1211rw is already doing this, maybe this patch is
acceptable...?

Anyway, I have your patch.  Please be patient.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/