Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone

[Rik van Riel]

On 12/11/2009 07:07 AM, Larry Woodman wrote:
> Minchan Kim wrote:
> > I like this. but why do you select default value as constant 8?
> > Do you have any reason?
> >
> > I think it would be better to select the number proportional to NR_CPU.
> > ex) NR_CPU * 2 or something.
> >
> > Otherwise looks good to me.
> >
> > Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
> This is a per-zone count so perhaps a reasonable default is the number
> of CPUs on the
> NUMA node that the zone resides on ?

One reason I made it tunable is so people can easily test
what a good value would be :)

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/