[tip:perf/urgent] hw-breakpoints: Handle bad modify_user_hw_breakpoint off-case return value

From: tip-bot for Frederic Weisbecker
Date: Fri Dec 11 2009 - 06:07:56 EST


Commit-ID: 99ac64c826e62a07e5818cfde620be4d524f1edf
Gitweb: http://git.kernel.org/tip/99ac64c826e62a07e5818cfde620be4d524f1edf
Author: Frederic Weisbecker <fweisbec@xxxxxxxxx>
AuthorDate: Fri, 11 Dec 2009 11:58:42 +0100
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Fri, 11 Dec 2009 12:03:53 +0100

hw-breakpoints: Handle bad modify_user_hw_breakpoint off-case return value

While converting modify_user_hw_breakpoint() return value, we
forgot to handle the off-case. It's not returning a pointer
anymore.

This solves the build warning reported by Stephen Rothwell against
linux-next.

Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Prasad <prasad@xxxxxxxxxxxxxxxxxx>
LKML-Reference: <1260529122-6260-1-git-send-regression-fweisbec@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Cc: Prasad <prasad@xxxxxxxxxxxxxxxxxx>
---
include/linux/hw_breakpoint.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 69f07a9..41235c9 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -93,7 +93,7 @@ register_user_hw_breakpoint(struct perf_event_attr *attr,
struct task_struct *tsk) { return NULL; }
static inline int
modify_user_hw_breakpoint(struct perf_event *bp,
- struct perf_event_attr *attr) { return NULL; }
+ struct perf_event_attr *attr) { return -ENOSYS; }
static inline struct perf_event *
register_wide_hw_breakpoint_cpu(struct perf_event_attr *attr,
perf_overflow_handler_t triggered,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/