Re: [PATCH 04/41] VFS: Remove unnecessary micro-optimization in cached_lookup()

From: Valerie Aurora
Date: Thu Dec 10 2009 - 16:30:23 EST


On Sun, Nov 29, 2009 at 09:07:39PM -0500, Erez Zadok wrote:
> In message <1256152779-10054-5-git-send-email-vaurora@xxxxxxxxxx>, Valerie Aurora writes:
> > From: Jan Blunck <jblunck@xxxxxxx>
> >
> > d_lookup() takes rename_lock which is a seq_lock. This is so cheap
> > it's not worth calling lockless __d_lookup() first from
> > cache_lookup(). Rename cached_lookup() to cache_lookup() while we're
> > there.
>
> Val, this is another patch unrelated to union mounts, an
> optimization/simplification of the VFS code. I think you need to try and
> push such VFS patches upstream more quickly, so as to reduce the set of UM
> patches you have to maintain.

I agree. We posted them separately once and will do so again.

-VAL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/