Re: [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support

[Corentin Chary]

On Thu, Dec 10, 2009 at 11:14 AM, Pavel Machek <pavel@xxxxxx> wrote:
> On Thu 2009-12-10 11:38:00, Corentin Chary wrote:
>> On Thu, Dec 10, 2009 at 11:09 AM, Pavel Machek <pavel@xxxxxx> wrote:
>> > On Tue 2009-12-08 15:26:09, Ike Panhc wrote:
>> >> From: Ike Panhc <ikepanhc@xxxxxxxxxxxxx>
>> >>
>> >> This patch is to enable the LenovoCare LED support on Lenovo SL laptop. Based
>> >> on the found of the control interface by Alexandre Rostovtsev
>> >>
>> >> Turn on the LenovoCare LED:
>> >>  (As root privileges) echo 1 > /sys/class/leds/asus\:\:LenovoCare/brightness
>> >> Trun off the LenovoCare LED:
>> >>  (As root privileges) echo 0 > /sys/class/leds/asus\:\:LenovoCare/brightness
>> >>
>> >> The patch against current checkout of acpi4asus is below.
>> >
>> > Is the driver severely misnamed by now? I believe Lenovo and ASUS are
>> > pretty different firms...
>> >
>>
>> Lenovo ship DSDT with similar ATKD interace.
>> See http://git.iksaif.net/?p=acpi4asus.git;a=commitdiff;h=31a38147625c283b58137db45e7507cd1e49aa05
>>
>
> So what? Rename the driver... having Asus::lenovocare led is just wrong.

asus::lenovocare led won't be in asus-laptop (see the whole discussion).

All specific lenovo things will be in a new lenevo specific driver.
asus-laptop also support some MEDION, JVC or VICTOR laptops, but these
are only exceptions.

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/