Re: [PATCH 7/12] drivers/s390: Correct size given to memset

[Heiko Carstens]

On Wed, Dec 09, 2009 at 08:24:28PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
> 
> Memset should be given the size of the structure, not the size of the pointer.
...
> -	memset(tcat, 0, sizeof(tcat));
> +	memset(tcat, 0, sizeof(*tcat));
>  	/* Calculate tcw input/output count and tcat transport count. */
>  	count = calc_dcw_count(tccb);
>  	if (tcw->w && (tcw->flags & TCW_FLAGS_OUTPUT_TIDA))
> @@ -269,7 +269,7 @@ EXPORT_SYMBOL(tccb_init);
>   */
>  void tsb_init(struct tsb *tsb)
>  {
> -	memset(tsb, 0, sizeof(tsb));
> +	memset(tsb, 0, sizeof(*tsb));

Applied. Thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/