Re: [PATCH 2/2] cfq-iosched: Take care of corner cases of group losing share due to deletion

[Jeff Moyer]

Vivek Goyal <vgoyal@xxxxxxxxxx> writes:

> Reported-by: Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx> 
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

> +	/*
> +	 * If think times is less than a jiffy than ttime_mean=0 and above
> +	 * will not be true. It might happen that slice has not expired yet
> +	 * but will expire soon (4-5 ns) during select_queue(). To cover the

4-5ns?  I'm not sure why you chose these numbers.  Is that what you saw
in testing?  Anyway, I'm ok with the change, I dislike the reference to
time when a single jiffy could be up to 10ms.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/