Re: [PATCH] Coding style correction on some drivers that use GenericHDLC

From: walter harms
Date: Wed Dec 09 2009 - 10:43:53 EST




Jan Yenya Kasprzak schrieb:
> Rudy Matela wrote:
> : Added a space separating some if/switch/while keywords from the following
> : parenthesis to conform to the CodingStyle.
>
> Hello,
>
> I am not sure whether it is necessary to fix formating mistakes in
> a driver which is in deep freeze and the hardware is not produced anymore,
> but whatever.
>
> Acked-By: Jan "Yenya" Kasprzak <kas@xxxxxxxxxx>
>
> -Yenya
>
> : Signed-off-by: Rudy Matela <rudy.matela@xxxxxxxxx>
> : ---
> :
> : drivers/net/wan/cosa.c | 10 +++++-----
> : drivers/net/wan/hdlc_cisco.c | 8 ++++----
> : drivers/net/wan/hdlc_x25.c | 4 ++--
> : 3 files changed, 11 insertions(+), 11 deletions(-)
> :
> : diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
> : index b36bf96..f0bd70f 100644
>

It is ok until the driver is removed, if this "issue" is not fixed it will
trigger any check-coding-style and generate new patches. Since it involves
no code changes it is harmless.

re,
wh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/