Re: [RFC][PATCHSET] mremap/mmap mess

From: Peter Zijlstra
Date: Wed Dec 09 2009 - 08:39:46 EST


On Wed, 2009-12-09 at 13:24 +0000, Al Viro wrote:

> > That is, IIRC the problem is that you need to have the argc/env in place
> > for the binfmt engine thing, and need to have ran the binfmt engine
> > thing before you know the personality.
> >
> > As to your idea, if that were feasible we could do without the copy and
> > simply steal the pages directly from the old mm.
>
> *raised brows*
> Old mm may bloody well be still shared, so I'd be vary of trying that -
> there's a lot of nasty surprises we could get on that way.

Good point, but I think we might be able to do the copy from old to new
in flush_old_exec() if we can get the binfmt things to pass the right
address along (or set it in the brpm struct). It looks like it has clue
about personality at that point.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/