Re: [patch V2 sched: Protect sched_rr_get_param access totask->sched_class

From: Peter Zijlstra
Date: Wed Dec 09 2009 - 03:34:08 EST


On Wed, 2009-12-09 at 09:32 +0100, Thomas Gleixner wrote:
> sched_rr_get_param calls task->sched_class->get_rr_interval(task)
> without protection against a concurrent sched_setscheduler() call
> which modifies task->sched_class.
>
> Serialize the access with task_rq_lock(task) and hand the rq pointer
> into get_rr_interval() as it's needed at least in the sched_fair
> implementation.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/