Re: [patch 2/2] x86,apic: Use logical OR in noop-write operation

From: Cyrill Gorcunov
Date: Tue Dec 08 2009 - 15:48:52 EST


On Tue, Dec 08, 2009 at 06:53:18PM +0300, Cyrill Gorcunov wrote:
> For apic noop'ified we have to use logical OR statement,
> otherwise any write on systems shipped with 82489DX
> (where apic presence bit can't be retrieved via cpuid)
> will not trigger the warning which is not desired.
>
...

Ingo please dont apply this patch. Perhaps we may warn unconditionally
(as Peter marked) which would be more clear approach indeed. Need more
time to check all code flows.

Sorry for inconvenience.

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/