Re: [Patch] selinux: remove a useless return

[Cong Wang]

Dan Carpenter wrote:
> On 12/3/09, Amerigo Wang <amwang@xxxxxxxxxx> wrote:
> > The last return is unreachable, remove the 'return'
> > in default, let it fall through.
> >
> > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> > Cc: James Morris <jmorris@xxxxxxxxx>
> > Cc: Eric Paris <eparis@xxxxxxxxxxxxxx>
> >
> > ---
> >
> > diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
> > index b5407f1..718823d 100644
> > --- a/security/selinux/ss/mls.c
> > +++ b/security/selinux/ss/mls.c
> > @@ -542,7 +542,7 @@ int mls_compute_sid(struct context *scontext,
> >  		/* Use the process effective MLS attributes. */
> >  		return mls_context_cpy_low(newcontext, scontext);
> >  	default:
> > -		return -EINVAL;
> > +		/* Fallthrough */
> >  	}
> >  	return -EINVAL;
> >  }
>
> I don't think this compiles.  GCC doesn't let you end a switch block
> with a label.
>
> I also have sent the selinux people a patch that didn't compile by
> mistake.  Afterward I wrote this script so hopefully I won't mess up
> again.


Oops, sorry for this, my bad.
Thanks for your patch.

> #!/bin/bash -e
>
> files=$(grep +++ /home/dcarpenter/var/mail/postponed-msgs | cut -f 1 |
> cut -b 5-)
> for file in $files ; do
> 	file=${file/devel\//}
> 	file=${file/new\//}
> 	kchecker $file
> 	if which sparse | grep -q sparse ; then
> 		kchecker --sparse $file
> 	fi
> done
>
>
> You will have to change the path names.  Hm....  Also you will have to
> get the kchecker script from the smatch_data/ directory of smatch
> (http://repo.or.cz/w/smatch.git).

Thanks for the info! I will have a try.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/